Re: [update, rev. 6] Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5)

[Arve Hjønnevåg]

On Thu, Mar 12, 2009 at 1:43 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>
> +void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
> +{
> +       if (suspend) {
> +               if (desc->action && (desc->action->flags & IRQF_TIMER))
> +                       return;

Don't you want "(!desc->action || ..." here to avoid enabling unused
interrupts on resume?

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/