Re: [Tux3] Tux3 report: Tux3 Git tree available

From: Andrew Morton
Date: Thu Mar 12 2009 - 16:04:48 EST


On Fri, 13 Mar 2009 01:18:29 +0900
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:

> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:
>
> > - When 'bh' is known to be non-NULL, use put_bh() rather than brelse().
>
> It sounds strange. Almost all bh is non-NULL. This means we are going to
> replace almost all brelse() by put_bh()?
>

Well.. you can make up your own mind about this. If you see benefit
in the NULL-checking and extra debugging which brelse() provides then
continue to use brelse().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/