Re: [PATCH] 8139cp: allow to set mac address on running device

From: Michal Schmidt
Date: Thu Mar 12 2009 - 13:11:37 EST


On Thu, 12 Mar 2009 17:27:31 +0100
Jiri Pirko <jpirko@xxxxxxxxxx> wrote:

> + cpw32_f(MAC0 + 0, le32_to_cpu (*(__le32 *) (dev->dev_addr +
> 0)));
> + cpw32_f(MAC0 + 4, le32_to_cpu (*(__le32 *) (dev->dev_addr +
> 4)));

You're writing to the card, so using *_to_cpu looks suspicious.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/