Re: [PATCH 1/2] x86: unify kmap_atomic_pfn() andiomap_atomic_prot_pfn()

[Ingo Molnar]

* Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> 2009/3/12 Ingo Molnar <mingo@xxxxxxx>:
> >
> > * Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> >
> >> 2009/3/12 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> >> > On Wed, 11 Mar 2009, Akinobu Mita wrote:
> >> >> kmap_atomic_pfn() and iomap_atomic_prot_pfn() are almost same except
> >> >> pgprot. This patch removes the code duplication for these two functions.
> >> >
> >> > How exaclty does this compile with CONFIG_HIGHMEM=n ?
> >> >
> >>
> >> Oh, I didn't try without CONFIG_HIGHMEM.
> >
> > i had it applied in testing locally and didnt see problems so
> > far. Let me know if you can see any problems.
> 
> It actually didn't compile with CONFIG_HIGHMEM=n as Thomas 
> pointed out.
> 
> arch/x86/mm/iomap_32.c:49: undefined reference to 
> `kmap_atomic_prot_pfn'

hm, i didnt see any build failures myself. Could you please send 
the .config that triggers it?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/