Re: [PATCH] eliminate spurious pointless WARN_ON()s

From: Ingo Molnar
Date: Thu Mar 12 2009 - 08:19:48 EST



* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> Namely during early boot, the panic() or BUG() paths may end
> up in smp_call_function_*() with just a single online CPU. In
> that situation the warnings generated are not only
> meaningless, but also result in relevant output being
> cluttered.
>
> Therefore, defer the WARN_ON() checks until after the
> (unaffected from the problem that is being attempted to be
> detected here) cases have been handled.

Makes sense probably - but please send a patch against -tip as
we've got quite many changes queued up in that area and your
patch does not apply cleanly:

patching file kernel/smp.c
Hunk #1 FAILED at 222.
Hunk #2 FAILED at 229.
Hunk #3 FAILED at 325.
Hunk #4 FAILED at 344.
4 out of 4 hunks FAILED -- rejects in file kernel/smp.c

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/