Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

[graff yang]

On Wed, Mar 11, 2009 at 3:57 PM, Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
> On Wed, Mar 11, 2009 at 03:29, Â<graff.yang@xxxxxxxxx> wrote:
>> +static int __devinit bfin_sir_probe(struct platform_device *pdev)
>> +{
>> + Â Â Â struct net_device *dev;
>> + Â Â Â struct bfin_sir_self *self;
>> + Â Â Â unsigned int baudrate_mask;
>> + Â Â Â struct bfin_sir_port *sir_port;
>> + Â Â Â int err;
>> +
>> + Â Â Â err = peripheral_request_list(per[pdev->id], DRIVER_NAME);
>
> what if pdev->id is set to 12512 ?

The pdev->id is defined in board files, for example, uart0 should be 0.
>
>> + Â Â Â switch (max_rate) {
>> + Â Â Â default:
>> + Â Â Â Â Â Â Â printk(KERN_WARNING "bfin_sir: Invalid maximum baud rate, using 9600\n");
>
> dev_warn(&dev->dev,....) ?

Here the netdev has not been registered.

> -mike
>



-- 
-Graff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/