Re: [PATCH] proc: fix kflags to uflags copying in /proc/kpageflags

[KOSAKI Motohiro]

> Fix kpf_copy_bit(src,dst) to be kpf_copy_bit(dst,src) to match the
> actual call patterns, e.g. kpf_copy_bit(kflags, KPF_LOCKED, PG_locked).
> 
> This misplacement of src/dst only affected reporting of PG_writeback,
> PG_reclaim and PG_buddy. For others kflags==uflags so not affected.
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
> ---
> 
> This is a tested and trivial no-side-effect fix.
> I'd suggest it for 2.6.29-rc7 and 2.6.28.X kernels.
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 2d13451..e998383 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -80,7 +80,7 @@ static const struct file_operations proc_kpagecount_operations = {
>  #define KPF_RECLAIM    9
>  #define KPF_BUDDY     10
>  
> -#define kpf_copy_bit(flags, srcpos, dstpos) (((flags >> srcpos) & 1) << dstpos)
> +#define kpf_copy_bit(flags, dstpos, srcpos) (((flags >> srcpos) & 1) << dstpos)

Good catch! :)
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>


but don't worry. the number of this interface user is very few.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/