Re: [git-pull -tip V2] x86: cpu architecture debug code

From: Valdis . Kletnieks
Date: Tue Mar 10 2009 - 15:57:17 EST


On Tue, 10 Mar 2009 16:20:29 BST, Ingo Molnar said:

> If you look at arch/x86/mm/fault.c, they are sorted by length,
> and within the same length they are sorted alphabetically.

Huh? I just did a 'git pull' of Linus's tree, and I see fault.c looking like:

#include <linux/signal.h>
#include <linux/sched.h>
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/types.h>
#include <linux/ptrace.h>
#include <linux/mmiotrace.h>
#include <linux/mman.h>
#include <linux/mm.h>
#include <linux/smp.h>
#include <linux/interrupt.h>

Not sure how it's sorted, but it's appparently not by length first. Also,
wouldn't logical interdependency count for something here, including stuff
in the order needed?

Attachment: pgp00000.pgp
Description: PGP signature