[PATCH 2/6] Fix interface clock existance check.

From: Atal Shargorodsky
Date: Tue Mar 10 2009 - 12:05:48 EST


When enabling/disabling the iterface clock, the question
to be asked is if this clock exists rather than to
decide about it's existance by retrieving the chip version.
It can be done only once at init time.

Signed-off-by: Atal Shargorodsky <ext-atal.shargorodsky@xxxxxxxxx>
---
drivers/watchdog/omap_wdt.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index 5b72c7c..05dc55a 100644
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -145,7 +145,7 @@ static int omap_wdt_open(struct inode *inode, struct file *file)
if (test_and_set_bit(1, (unsigned long *)&(wdev->omap_wdt_users)))
return -EBUSY;

- if (cpu_is_omap24xx() || cpu_is_omap34xx())
+ if (wdev->mpu_wdt_ick)
clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */

clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */
@@ -177,7 +177,7 @@ static int omap_wdt_release(struct inode *inode, struct file *file)

omap_wdt_disable(wdev);

- if (cpu_is_omap24xx() || cpu_is_omap34xx())
+ if (wdev->mpu_wdt_ick)
clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */

clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */
@@ -344,7 +344,7 @@ static int __init omap_wdt_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, wdev);

/* enable clocks for register access */
- if (cpu_is_omap24xx() || cpu_is_omap34xx())
+ if (wdev->mpu_wdt_ick)
clk_enable(wdev->mpu_wdt_ick); /* Enable the interface clock */

clk_enable(wdev->mpu_wdt_fck); /* Enable the functional clock */
@@ -369,7 +369,7 @@ static int __init omap_wdt_probe(struct platform_device *pdev)
__raw_writel(0x01, wdev->base + OMAP_WATCHDOG_SYS_CONFIG);

/* disable clocks since we don't need them now */
- if (cpu_is_omap24xx() || cpu_is_omap34xx())
+ if (wdev->mpu_wdt_ick)
clk_disable(wdev->mpu_wdt_ick); /* Disable the clock */
clk_disable(wdev->mpu_wdt_fck); /* Disable the clock */

--
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/