Re: [patch 2/2] fs: introduce mnt_clone_write

From: Nick Piggin
Date: Tue Mar 10 2009 - 11:08:55 EST


On Tue, Mar 10, 2009 at 08:55:58AM -0600, Matthew Wilcox wrote:
> On Tue, Mar 10, 2009 at 03:38:01PM +0100, Nick Piggin wrote:
> > +EXPORT_SYMBOL_GPL(mnt_clone_write);
> > +EXPORT_SYMBOL_GPL(mnt_want_write_file);
>
> You don't add any users of these functions in this patch ... is there a
> good reason to export them?

Only to encourage modular code to use them (as a replacement for
mnt_want_write -- which itself is exported).

If that's not the right way to go, I don't mind waiting for a
user to turn up.


[I see many ioctls in btrfs (coming first in the alphabet) could
probably easily use mnt_want_write_file (otoh probably none are
so performance critical).]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/