Re: [PATCH] [net/irda]: new Blackfin on-chip SIR IrDA driver

[Mike Frysinger]

On Tue, Mar 10, 2009 at 07:25, graff yang wrote:
> On Tue, Mar 10, 2009 at 4:03 PM, Mike Frysinger wrote:
>> On Tue, Mar 10, 2009 at 03:29, Â<graff.yang@xxxxxxxxx> wrote:
>> > + Â Â Â baudrate_mask = IR_9600;
>> > +
>> > + Â Â Â switch (max_rate) {
>> > + Â Â Â case 115200:
>> > + Â Â Â Â Â Â Â baudrate_mask |= IR_115200;
>> > + Â Â Â case 57600:
>> > + Â Â Â Â Â Â Â baudrate_mask |= IR_57600;
>> > + Â Â Â case 38400:
>> > + Â Â Â Â Â Â Â baudrate_mask |= IR_38400;
>> > + Â Â Â case 19200:
>> > + Â Â Â Â Â Â Â baudrate_mask |= IR_19200;
>> > + Â Â Â }
>>
>> what if someone specified max_rate = 1231245 ?
>
> The initial value of baudrate_mask is IR_9600.

i meant in terms of the user being notified it's a bogus value.  what
if they did max_rate=576000 ?  clearly they meant 57600, but they hit
"0" too many times ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/