Re: [PATCH v2] add function spin_event_timeout()

From: Timur Tabi
Date: Mon Mar 09 2009 - 11:34:35 EST


Will Newton wrote:

> Are you sure you want to evaluate condition a second time when
> returning? Some memory mapped registers don't have a stable value so
> e.g. the first test could succeed but the return value could still be
> zero.

Ah, good point. I was hoping to keep the loop simple by combining the
two test conditions, but I guess that's not going to work.

v3 coming up.

--
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/