Re: hp accelerometer: add freefall detection

From: Pavel Machek
Date: Sun Mar 08 2009 - 17:14:41 EST


On Sat 2009-02-14 17:01:01, Frans Pop wrote:
> Hi Pavel,
>
> > +++ b/drivers/hwmon/lis3lv02d.c
> [...]
> > +static int lis3lv02d_misc_open(struct inode *inode, struct file *file)
> [...]
> > + if (ret) {
> > + clear_bit(0, &adev.misc_opened);
> > + printk(KERN_ERR DRIVER_NAME ": IRQ%d allocation failed\n", ad
> > + return -EBUSY;
> > + }
> > + lis3lv02d_increase_use(&adev);
> > + printk("lis3: registered interrupt %d\n", adev.irq);
>
> Is this a debug printk that should be removed altogether or should it
> be given a proper format and KERN_DEBUG?

It should be deleted, yes. I'll prepare the patch once previous
changes are merged.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/