Re: [PATCHSET x86/core/percpu] improve the first percpu chunkallocation
From: Ingo Molnar
Date: Tue Feb 24 2009 - 16:17:35 EST
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git
> > > tj-percpu
ok, but these seem to be genuinely yours.
one build failure:
arch/x86/kernel/setup_percpu.c: In function âsetup_per_cpu_areasâ:
arch/x86/kernel/setup_percpu.c:442: error: âptrâ undeclared (first use in this function)
arch/x86/kernel/setup_percpu.c:442: error: (Each undeclared identifier is reported only once
arch/x86/kernel/setup_percpu.c:442: error: for each function it appears in.)
one new warning:
mm/percpu.c: In function âpcpu_mapâ:
mm/percpu.c:604: warning: unused variable âlastâ
and one tip:master merge impact due to API change:
kernel/trace/trace_functions_graph.c: In function âgraph_trace_closeâ:
kernel/trace/trace_functions_graph.c:836: error: implicit declaration of function âpercpu_freeâ
that's free_percpu() now, right?
Btw., why was this rename done? We generally standardize on
hierarchical names, going from the more general to the more
specific names, left to right. So we have
<subsystem>_<functionality>_<subtype> sort of names generally.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/