Re: [OpenWrt-Devel] [PATCH] bcm47xx: Fix GPIO API return codes
From: Florian Fainelli
Date: Sun Feb 15 2009 - 08:28:16 EST
Hi Michael,
Le Saturday 14 February 2009 21:27:19 Michael Buesch, vous avez écrit :
> The GPIO API is supposed to return 0 or a negative error code,
> but the SSB GPIO functions return the bitmask of the GPIO register.
> Fix this by ignoring the bitmask and always returning 0. The SSB GPIO
> functions can't fail.
At some point we might want to convert the existing board code to use gpiolib.
I will try to come up with a patch for this later this afternoon.
Otherwise, your patch looks good.
--
Best regards, Florian Fainelli
Email : florian@xxxxxxxxxxx
http://openwrt.org
-------------------------------
Attachment:
signature.asc
Description: This is a digitally signed message part.