Re: [PATCH 1/1] x86_64: fix s3 fail path

[Ingo Molnar]

* Rafael J. Wysocki <rjw@xxxxxxx> wrote:

> On Saturday 14 February 2009, Jiri Slaby wrote:
> > Rafael J. Wysocki napsal(a):
> > > On Monday 09 February 2009, Jiri Slaby wrote:
> > >> As acpi_enter_sleep_state can fail, take this into account in
> > >> do_suspend_lowlevel and don't return to the do_suspend_lowlevel's
> > >> caller. This would break (currently) fpu status and preempt count.
> > >>
> > >> Technically, this means use `call' instead of `jmp' and `jmp' to
> > >> the `resume_point' after the `call' (i.e. if
> > >> acpi_enter_sleep_state returns=fails). `resume_point' will handle
> > >> the restore of fpu and preempt count gracefully.
> > >>
> > >> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> > >> Cc: Len Brown <lenb@xxxxxxxxxx>
> > >> Cc: Pavel Machek <pavel@xxxxxxx>
> > >> Cc: Rafael J. Wysocki <rjw@xxxxxxx>
> > > 
> > > What kernel is this patch against?  It doesn't apply to the mainline.
> > 
> > It is applicable even after
> > [PATCH v2 1/1] x86_64: acpi/wakeup_64 cleanup
> > from
> > http://lkml.org/lkml/2009/2/7/101
> > which is not present anywhere so far.
> 
> Thanks, I'm going to push both patches through Len, if Ingo doesn't mind.

Fine with me.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/