Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

From: Alessandro Zummo
Date: Sat Feb 14 2009 - 17:55:00 EST


On Sat, 14 Feb 2009 17:38:11 -0500
Andres Salomon <dilinger@xxxxxxxxxx> wrote:

> > I've been suggested to move it within geode_32. the driver is
> > probably pretty geode specific anyhow.
> >
>
>
> If the whole point is to make the cs553x GPIO stuff portable (and to use
> the portable API), then what's the point if we know that it can/will
> be used by non-x86 platforms?
>
> We already have a cs553x GPIO char device, a geode GPIO lib that
> works (but has flaws).. I'm all for creating The One True CS553x GPIO
> API, but I'd consider something that's geode (and x86)-specific to be
> a waste of time.

GPIO lib is generic enough for most archs to use it and my driver uses it
Anyway I did my homework.. I will submit a revision with the latest suggested
changes... if accepted I will be happy to maintain it.



--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/