Re: [PATCH] olpc: fix model detection without OFW

From: Ingo Molnar
Date: Sat Feb 14 2009 - 16:43:51 EST



* Andres Salomon <dilinger@xxxxxxxxxx> wrote:

> As discussed on IRC, this has the Dilinger Seal Of Approval (tm).
>
> Acked-by: Andres Salomon <dilinger@xxxxxxxxxx>

> On Fri, 13 Feb 2009 20:56:18 -0500
> Chris Ball <cjb@xxxxxxxxxx> wrote:
>
> > Harvey's endianness patch (e51a1ac2dfca9ad869471e88f828281db7e810c0)

> > breaks model comparison on OLPC; the value 0xc2 needs to be scaled
> > up by olpc_board(). The pre-patch version was wrong, but accidentally
> > worked anyway (big-endian 0xc2 is big enough to satisfy all other
> > board revisions, but little endian 0xc2 is not).
> >
> > Signed-off-by: Chris Ball <cjb@xxxxxxxxxx>

Applied to tip:x86/urgent [for v2.6.29], thanks guys!

Did i get the impact-line below right?

Ingo

---------------->