Re: [PATCH 1.5/2] generic-smp: fix initial quiesent count.

From: Peter Zijlstra
Date: Sat Feb 14 2009 - 16:17:24 EST


On Sat, 2009-02-14 at 15:46 +0100, Peter Zijlstra wrote:
> first compile, then send out...
>
> ---
> Subject: generic-smp: fix initial quiesent count.
> From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Date: Sat Feb 14 15:36:07 CET 2009
>
> If we start with a quiesent sequence count of 0, we'll match the initial stamp
> values of the cfd_data, and never make any progress.
>
> To avoid getting stuck in this situation, start out with an increased quiesent
> sequence count.

OK, so this is not going to fix the problem in generic. Its still
possible to end up with the original issue.

We'd need a callback list to free used entries, much like regular RCU,
this quiesent sequence count's wrapping just seems too brittle.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/