Re: [PATCH]: drm: radeon: Use surface for PCI GART table.

[Jerome Glisse]

On Sat, 2009-02-14 at 02:04 -0800, David Miller wrote:
> From: Michel DÃnzer <michel@xxxxxxxxxxx>
> Date: Sat, 14 Feb 2009 10:59:59 +0100
> 
> > On Sat, 2009-02-14 at 01:51 -0800, David Miller wrote:
> > > This allocates a physical surface for the PCI GART table, this way no
> > > matter what other surface configurations exist the GART table will
> > > always be seen by the hardware properly.
> > 
> > BTW, I don't think the swapping settings affect GPU access to the table,
> > only CPU access, but this is a good solution anyway.
> 
> They absolutely and positively do effect GPU access to the table.
> I've proven it with many conclusive tests over the past 3 days.
> 
> > This is only really necessary on big endian, but other than that:
> > 
> > Acked-By: Michel DÃnzer <daenzer@xxxxxxxxxx>
> 
> Thanks.

This will need to be revisited with KMS as i think we should not allow
userspace to play with surface. Maybe we could setup surface on BO
mapping and disable them on bo unmapping (we would to register some
callback on vmclose).

Cheers,
Jerome Glisse

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/