Re: [PATCH next] Staging: pohmelfs should depend on CRYPTO

From: Alexander Beregalov
Date: Sat Feb 14 2009 - 06:02:25 EST


2009/2/14 Evgeniy Polyakov <zbr@xxxxxxxxxxx>:
> On Fri, Feb 13, 2009 at 06:06:54PM +0300, Alexander Beregalov (a.beregalov@xxxxxxxxx) wrote:
>>
>>
>> Signed-off-by: Alexander Beregalov <a.beregalov@xxxxxxxxx>
>
> Doesn't subsystem selection also forces higher level selection, i.e.
> selecing CRYPTO_BLKCIPHER also forces CRYPTO selection? If it is not the
> case, then your patch is definitely valid.
No, it does not. The kernel fails to build if CRYPTO was disabled
before enabling POHMELFS.
>
>> ---
>>
>> drivers/staging/pohmelfs/Kconfig | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/pohmelfs/Kconfig b/drivers/staging/pohmelfs/Kconfig
>> index f150ecb..4c6276b 100644
>> --- a/drivers/staging/pohmelfs/Kconfig
>> +++ b/drivers/staging/pohmelfs/Kconfig
>> @@ -1,6 +1,7 @@
>> config POHMELFS
>> tristate "POHMELFS filesystem support"
>> select CONNECTOR
>> + select CRYPTO
>> select CRYPTO_BLKCIPHER
>> select CRYPTO_HMAC
>> help
>
> --
> Evgeniy Polyakov
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/