Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__

From: Jeremy Fitzhardinge
Date: Fri Feb 13 2009 - 13:53:25 EST


Ingo Molnar wrote:
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

Ingo Molnar wrote:
From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@xxxxxxx>
Date: Fri, 13 Feb 2009 13:36:47 +0100
Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
I think this is wrong in principle. There should never be a reason to include a non-_types.h into asm.

(Fine as a build fix, of course.)

Agreed - but it needs fixes to the .S files, these assembly files
include pgtable.h or page.h:

Piecemeal, or one sweep?

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/