Re: [PATCH 2/7] x86: memtest: introduce array to store memtest patterns

From: H. Peter Anvin
Date: Fri Feb 13 2009 - 12:52:55 EST


Andreas Herrmann wrote:
> -#define _MAX_MEM_PATTERNS 4
> +static unsigned long patterns[] = {
> + 0UL,
> + -1UL,
> +#ifdef CONFIG_X86_64
> + 0x5555555555555555UL,
> + 0xaaaaaaaaaaaaaaaaUL,
> +#else
> + 0x55555555UL,
> + 0xaaaaaaaaUL,
> +#endif
> +};

Why not just use u64 for the pattern even on 32 bits?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/