Re: Acer Aspire One fan control

[Matthew Garrett]

On Thu, Feb 12, 2009 at 09:37:13PM +0100, Peter Feuerer wrote:

> Do you think it makes sense to add it as seperate kernelmodule or should I 
> patch another module, e.g. the drivers/misc/acer-wmi.c module?
> Should I try also to add the functionality of the 
> /proc/acpi/thermal_zone/THRM/* things in my first patch? Or just submit the 
> general functionality for controlling the fan and add additional things 
> step by step?

That depends on how you're doing it. Is the code available somewhere? If 
these io ports are also used by the firmware then you'll need to find 
ACPI methods to call to perform the fan control. If there aren't any 
then it's not safe to have a driver to do this.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/