Re: [PATCH] 4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopttry #2

From: David Miller
Date: Thu Feb 12 2009 - 19:59:42 EST


From: Clement LECIGNE <clement.lecigne@xxxxxxxxxx>
Date: Thu, 12 Feb 2009 13:35:45 +0100

> In function sock_getsockopt() located in net/core/sock.c, optval v.val
> is not correctly initialized and directly returned in userland in case
> we have SO_BSDCOMPAT option set.
>
> This dummy code should trigger the bug:
>
> int main(void)
> {
> unsigned char buf[4] = { 0, 0, 0, 0 };
> int len;
> int sock;
> sock = socket(33, 2, 2);
> getsockopt(sock, 1, SO_BSDCOMPAT, &buf, &len);
> printf("%x%x%x%x\n", buf[0], buf[1], buf[2], buf[3]);
> close(sock);
> }
>
> Here is a patch that fix this bug by initalizing v.val just after its declaration.

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/