Re: [PATCH 1/1] ipw2200, fix ipw io functions

[Zhu Yi]

On Fri, 2009-02-13 at 05:29 +0800, Jiri Slaby wrote:
>  /* alias to 8-bit direct read (low 4K of SRAM/regs), with debug
> wrapper */
> -#define ipw_read8(ipw, ofs) __ipw_read8(__FILE__, __LINE__, ipw, ofs)
> +#define ipw_read8(ipw, ofs) ({ \
> +       IPW_DEBUG_IO("%s %d: read_direct8(0x%08X)\n", __FILE__, __LINE__, \
> +                       (u32)(ofs)); \
> +       _ipw_read8(ipw, ofs); \
> +})

Please put a do {} while(0) for this and some of below macros as well.

Thanks,
-yi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/