Re: [PATCHv2 2/5] VFS: DazukoFS, stackable-fs, file access control

From: Eric W. Biederman
Date: Thu Feb 12 2009 - 15:14:19 EST


John Ogness <dazukocode@xxxxxxxxxx> writes:

> Patch 2: Creates /dev/dazukofs.0 for userspace applications to perform
> file access control. At this point, all applications are
> considered to be working together (in the same group).

Please use struct pid properly.

There is no guarantee that whoever opens /dev/dazukofs.0 will
be in the global pid namespace.

So you need to properly store a struct pid reference in your
data structures, and call pid_vnr just before you pass the value to userspace.

As it is your code is broken.


Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/