Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmdone
From: Sergei Shtylyov
Date: Wed Feb 11 2009 - 12:30:45 EST
Hello.
Bartlomiej Zolnierkiewicz wrote:
Bartlomiej Zolnierkiewicz wrote:
* Rename dma_timer_expiry() to ide_dma_sff_expiry() and export it.
* Add ->dma_expiry method
This name doesn't seem to make much sense. Why not leave it dma_timer_expiry?
Well, the name matches with hwif->expiry one + the downside of leaving it at
dma_timer_expiry is a need to reformat all struct ide_dma_ops instances...
How about just timer_expiry() then?
Thanks,
Bart
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/