Re: [PATCH -v4] futex: fix reference leak

From: Ingo Molnar
Date: Wed Feb 11 2009 - 12:25:19 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Subject: futex: fix reference leak
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> Catalin noticed that (38d47c1b7075: futex: rely on get_user_pages() for
> shared futexes) caused an mm_struct leak.
>
> Some tracing with the function graph tracer quickly pointed out that
> futex_wait() has exit paths with unbalanced reference counts.
>
> This regression was discovered by kmemleak.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Tested-by: "Pallipadi, Venkatesh" <venkatesh.pallipadi@xxxxxxxxx>
> Tested-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> Reported-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> ---
> kernel/futex.c | 53 ++++++++++++++++++++++++++++-------------------------
> 1 files changed, 28 insertions(+), 25 deletions(-)

Applied to tip:core/urgent, thanks guys!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/