Re: [PATCH 0/3] x86: Fix pt_regs passed by value

From: Ingo Molnar
Date: Wed Feb 11 2009 - 06:42:47 EST



* Brian Gerst <brgerst@xxxxxxxxx> wrote:

> Several syscalls and one trap handler currently rely on the pt_regs
> struct being passed in by value. This causes problems with stack
> protector, and can also cause problems with corruption due to tail-call
> optimization. Change them to use a pointer to the pt_regs struct
> instead.

looks good! Applied them to tip:core/percpu, thanks Brian.

Tejun, i have added your Acked-by lines. (let me know if that's
incorrect). The review feedback you gave is correct and can/should
be addressed in separate patches.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/