Re: [PATCH 1/1] NBD: fix I/O hang on disconnected nbds

From: Paul Clements
Date: Tue Feb 10 2009 - 16:53:58 EST


Andrew Morton wrote:
On Mon, 09 Feb 2009 13:21:51 -0500
Paul Clements <paul.clements@xxxxxxxxxxxx> wrote:

This problem was introduced by the new request handling thread code
("NBD: allow nbd to be used locally", 3/2008), which entered into mainline around 2.6.25.

Seems that the patch applies to 2.6.26, but not to 2.6.25.

OK, couldn't remember the exact timeframe.

The fix, which is fairly simple, is to restore the check for lo->sock
being NULL in do_nbd_request. This causes I/O to an uninitialized nbd to
immediately fail with an I/O error, as it did prior to the introduction of this bug.

I marked this as needing backporting into 2.6.26.x, 2.6.27.x and
2.6.28.x. OK?

Yes, that would be a good idea.

Thanks,
Paul


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/