Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag

From: Kyle Moffett
Date: Tue Feb 10 2009 - 16:12:22 EST


On Thu, Feb 5, 2009 at 3:26 AM, Floris Kraak <randakar@xxxxxxxxx> wrote:
> There are probably some real bugs in there. On the other hand there is
> some overhead to fixing the warnings. Kernel text size increase,
> possibly some CPU overhead from parsing the format string. Hopefully
> none of these calls are in really hot code paths ;-)

Actually, I would really suspect that CPU time would *decrease* for
most of these, because instead of groveling through the whole argument
string looking for '%' symbols we would do a single "%s" lookup
followed by a basic strncpy(dmesg_buffer + offset, arg,
dmesg_buffer_size - offset);

Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/