Re: [PATCH 1/2] tracing/sysprof: add missingtracing_{start,stop}_record_cmdline()

[Frederic Weisbecker]

On Tue, Feb 10, 2009 at 03:25:43PM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 
> > On Tue, Feb 10, 2009 at 01:31:45PM +0100, Ingo Molnar wrote:
> > > 
> > > * Ingo Molnar <mingo@xxxxxxx> wrote:
> > > 
> > > > * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> > > > 
> > > > > Add the missing pair tracing_{start,stop}_record_cmdline() to record well
> > > > > the cmdline associated with pid.
> > > > > 
> > > > > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > > > > ---
> > > > >  kernel/trace/trace_sysprof.c |    3 +++
> > > > >  1 files changed, 3 insertions(+), 0 deletions(-)
> > > > 
> > > > applied to tip/tracing/sysprof, thanks Frederic!
> > > 
> > > hm, causes a build failure:
> > > 
> > > kernel/built-in.o: In function `stack_trace_reset':
> > > trace_sysprof.c:(.text+0x3e91a): undefined reference to `tracing_stop_cmdline_record'
> > > kernel/built-in.o: In function `stack_trace_init':
> > > trace_sysprof.c:(.text+0x3e953): undefined reference to `tracing_start_cmdline_record'
> > > 
> > > 	Ingo
> > 
> > Sorry, this fixlet solves the problem:
> 
> Could you please send one combo patch? The patch was so small and was at
> the tail of tracing/sysprof that i didnt apply it after all.
> 
> 	Ingo


Ok.
I've dropped the build error example in the changelog, keeping only the reason
of the error, as this is a V2.
Tell me if you are fine with it.

--