Re: [PATCH] i8327: fix outb() parameter order

[Ingo Molnar]

* Clemens Ladisch <clemens@xxxxxxxxxx> wrote:

> In i8237A_resume(), when resetting the DMA controller, the parameters to
> dma_outb() were mixed up.
> 
> Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> 
> --- linux-2.6.orig/arch/x86/kernel/i8237.c
> +++ linux-2.6/arch/x86/kernel/i8237.c
> @@ -28,8 +28,8 @@ static int i8237A_resume(struct sys_devi
>  
>  	flags = claim_dma_lock();
>  
> -	dma_outb(DMA1_RESET_REG, 0);
> -	dma_outb(DMA2_RESET_REG, 0);
> +	dma_outb(0, DMA1_RESET_REG);
> +	dma_outb(0, DMA2_RESET_REG);
>  
>  	for (i = 0;i < 8;i++) {
>  		set_dma_addr(i, 0x000000);

Good catch, applied to tip:x86/urgent, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/