Re: [PATCH 08/11] x86: use asm .macro instead of cpp #define in entry_32.S

From: Jeremy Fitzhardinge
Date: Mon Feb 09 2009 - 20:18:58 EST


Tejun Heo wrote:
Hmm... I originally did the conversion because I had some .if trick in
SAVE_ALL which got removed later. Even after the removal, it
generally looked like a good idea as x86_64 asm was primarily using
.macro too. I do like being able to see the post-processing output of
cpp too but for assembler disassembling the output often seem to give
enough clue,
That's assuming that the file assembles. But if you're trying to assemble and the best error the assembler comes up with is "bad operand" on the line where you're using the macro, its extremely frustrating trying to work out where the problem actually lies.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/