Re: [PATCH net] gianfar: Fix boot hangs while bringing up gianfarethernet

From: David Miller
Date: Mon Feb 09 2009 - 17:59:20 EST


From: Jarek Poplawski <jarkao2@xxxxxxxxx>
Date: Mon, 9 Feb 2009 20:34:40 +0100

> gianfar: Fix boot hangs while bringing up gianfar ethernet
>
> Ira Snyder found that commit 8c7396aebb68994c0519e438eecdf4d5fa9c7844
> "gianfar: Merge Tx and Rx interrupt for scheduling clean up ring" can
> cause hangs. It's because there was removed clearing of interrupts in
> gfar_schedule_cleanup() (which is called by an interrupt handler) in
> case when netif scheduling has been disabled. This patch brings back
> this action and a comment.
>
> Reported-by: Ira Snyder <iws@xxxxxxxxxxxxxxxx>
> Reported-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> Bisected-by: Ira Snyder <iws@xxxxxxxxxxxxxxxx>
> Tested-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> Tested-by: Ira Snyder <iws@xxxxxxxxxxxxxxxx>
> Signed-by: Jarek Poplawski <jarkao2@xxxxxxxxx>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/