Re: [PATCH 4/5] tracing/core: drop the cpu field from trace_entry

[Steven Rostedt]

On Mon, 9 Feb 2009, Ingo Molnar wrote:

> 
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 
> > On Mon, Feb 09, 2009 at 10:53:24AM +0100, Ingo Molnar wrote:
> > > 
> > > * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> > > 
> > > > Impact: fix a bug on cpu output
> > > > 
> > > > While looking on the function tracer traces, I first cheered up:
> > > > 
> > > >             TASK-PID    CPU#    TIMESTAMP  FUNCTION
> > > >                | |       |          |         |
> > > >          firefox-4622  [081]  1315.790405: lapic_next_event <-clockevents_program_event
> > > >          firefox-4622  [178]  1315.790405: native_apic_mem_write <-lapic_next_event
> > > >          firefox-4622  [020]  1315.790406: perf_counter_unthrottle <-smp_apic_timer_interrupt
> > > > 
> > > > But no, actually I don't have so many cpus...
> > > 
> > > incidentally, Steve came up with the exact same patch :)
> > > 
> > > 	Ingo
> > 
> > Heh, I guess the moon inspired both of us in the name of tracing, or
> > something like that...
> 
> It was exactly at around the time Thomas complained over IRC
> about the visible CPU# breakage in the tracer output.
> 
> So i blame it on telepathy ;-)

Thomas was the full moon, his complaint to me was the reason I pushed it 
out ASAP.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/