Re: [PATCH 1/3] module: create a request_module_nowait()

[Arjan van de Ven]

On Mon, 9 Feb 2009 17:02:17 +1030
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Monday 09 February 2009 05:12:01 Arjan van de Ven wrote:
> > This patch changes this to use a request_module_nowait() function
> > macro instead, which just fires the modprobe off but doesn't wait
> > for it, and thus avoids the original deadlock entirely.
> 
> Nice, applied.  Made one change; I've taken to using the new-fangled
> bool type for flag args, for slight extra clarity.
> 
> (Which uncovered another interesting issue, which lead to several more
>  patches).
> 

for this case that's a bit unfortunate though.

the call usermode helper code takes 3 values, -1, 0 and 1.
Right now the code only uses 0 and 1, but I've been looking at
using -1 as well in this exact codepath in case there is a problem with
the 0 option (the 0 option waits for the exec but not the result, the
-1 waits for nothing)

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/