Re: [PATCH] softlockup: remove timestamp checking from hung_task

From: Ingo Molnar
Date: Mon Feb 09 2009 - 05:05:19 EST



* Mandeep Singh Baines <msb@xxxxxxxxxx> wrote:

> Patch against tip/core/softlockup
>
> ---
> Impact: saves sizeof(long) bytes per task_struct
>
> By guaranteeing that sysctl_hung_task_timeout_secs have elapsed between
> tasklist scans we can avoid using timestamps.
>
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxx>
> ---
> include/linux/sched.h | 1 -
> kernel/fork.c | 8 +++-----
> kernel/hung_task.c | 48 +++++++++---------------------------------------
> 3 files changed, 12 insertions(+), 45 deletions(-)

Nice simplification!

Applied to tip/core/softlockup, thanks Mandeep.

(i fixed the one scripts/checkpatch.pl error that your patch triggered)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/