Re: [patch 1/2] timerfd add flags check

From: Michael Kerrisk
Date: Sun Feb 08 2009 - 21:34:22 EST


On Mon, Feb 9, 2009 at 12:23 PM, Davide Libenzi <davidel@xxxxxxxxxxxxxxx> wrote:
> Like Michael requested, this patch adds a missing check for valid flags in
> timerfd_settime(), and make it return EINVAL in case some extra bits are
> set. If this is or not a -stable thing, it Greg decision.
> Should be queued by Andrew for .30, unless -stable and Linus decide to
> get it before, like Michael suggested.

When these two patches are applied against .29-rc3:

$ make
[...]
CC fs/timerfd.o
fs/timerfd.c: In function 'sys_timerfd_create':
fs/timerfd.c:190: error: implicit declaration of function 'invalid_clockid'
make[1]: *** [fs/timerfd.o] Error 1
make: *** [fs] Error 2


Cheers,

Michael

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/