Re: [PATCH 03/11] sdhci: Add type checking for IO memory accessors

[Pierre Ossman]

On Fri, 6 Feb 2009 21:06:48 +0300
Anton Vorontsov <avorontsov@xxxxxxxxxxxxx> wrote:

> A new restricted integer type introduced: sdhci_reg_t.
> 
> Header file now specifies registers via sdhci_reg() inline function.
> Only one place (not counting sdhci_def_*() accessors) need to cast
> a register back to an offset, i.e. sdhci_finish_command().
> 
> From now on sparse tool will warn about IO memory accessors misuses,
> for exampple:
> 
> sdhci_writeb(host, SDHCI_TIMEOUT_CONTROL, count);
> 
>   CHECK   sdhci.c
> sdhci.c:614:21: warning: incorrect type in argument 2 (different base types)
> sdhci.c:614:21:    expected unsigned char [unsigned] [usertype] val
> sdhci.c:614:21:    got restricted int
> sdhci.c:614:44: warning: incorrect type in argument 3 (different base types)
> sdhci.c:614:44:    expected restricted int [usertype] reg
> sdhci.c:614:44:    got unsigned char [unsigned] [assigned] [usertype] count
> 
> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> ---

Is this really a problem? It's a lot of noise in the code and I can't
really see this as a major issue, or even a minor one. :)

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Attachment: signature.asc
Description: PGP signature