Re: [PATCH] softlockup: convert read_lock in hung_task torcu_read_lock

From: Ingo Molnar
Date: Thu Feb 05 2009 - 13:13:50 EST



* Mandeep Singh Baines <msb@xxxxxxxxxx> wrote:

> Ingo Molnar (mingo@xxxxxxx) wrote:
> >
> > I've applied your patch to tip:core/softlockup, thanks Mandeep!
> >
>
> Oops, I put the conversion to rcu_read_lock in a seperate patch. I
> understand now the convention is to use a patch series only when the
> patches can be applied independently.

What you did is in fact the preferred approach: keep independent stuff
independent and make patches as gradual and split-up as possible. (as long
as the interim state is a working kernel too)

> ---
> Since the tasklist is protected by rcu list operations, it is safe
> to convert the read_lock()s to rcu_read_lock().
>
> Suggested-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxx>
> ---
> kernel/hung_task.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Applied to tip:core/softlockup, thanks!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/