Re: [PATCH 2/2 RESEND] platform: introduce module id table for platform devices

From: Eric Miao
Date: Tue Feb 03 2009 - 22:52:51 EST


On Wed, Feb 4, 2009 at 9:16 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Mon, Feb 02, 2009 at 06:11:48PM +0800, Eric Miao wrote:
>> >
>> > surely you mean PLATFORM_NAME_SIZE in this struct?
>>
>> Indeed, patch updated below (and as attached):
>
> With this patch, I get the following warning:
> drivers/base/platform.c:598: warning: assignment discards qualifiers from pointer target type
>
> Also, don't put platform_match_id() underneath the comments for
> platform_match(), that will only confuse the kernel-doc scripts and any
> developer looking at the code.
>
> Care to fix it up and resend?
>

OK, updated patch below: