Re: [PATCH] w35und: fix usb_control_msg() error handling inwb35_probe()

[Pavel Machek]

On Thu 2009-01-22 20:25:06, Sandro Bonazzola wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Pavel Machek ha scritto:
> >> From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >>
> >> If successful, the usb_control_msg() function returns the number of
> >> bytes transferred. Fix up wb35_probe() to only bail out if the function
> >> returns a negative number.
> >>
> >> Reported-by: Sandro Bonazzola <sandro.bonazzola@xxxxxxxxx>
> >> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> > 
> > Acked-by: Pavel Machek <pavel@xxxxxxx>
> 
> Ok, tested. Here is the result:
> 
> # uname -a
> Linux arilinn 2.6.29-rc2-00013-gf3b8436-dirty #1 Thu Jan 22 19:39:23 CET 2009
> x86_64 AMD Athlon(tm) 64 Processor 3500+ AuthenticAMD GNU/Linux
> 
> Inserting the USB device:
> # dmesg
> usb 1-3: new high speed USB device using ehci_hcd and address 4
> usb 1-3: New USB device found, idVendor=18e8, idProduct=6201
> usb 1-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> usb 1-3: Product: Usb2Wlan
> usb 1-3: Manufacturer: WINBOND
> usb 1-3: SerialNumber: 101d350112
> usb 1-3: configuration #1 chosen from 1 choice
> w35und: module is from the staging directory, the quality is unknown, you have
> been warned.
> wmaster0 (usb): not using net_device_ops yet
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This looks like a key clue...

Maybe you could try _current_ w35und on 2.6.28 or something like that?
I have feeling that networking core changed in incompatible way here.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/