Re: [PATCH 4/5] debugfs: introduce stub for debugfs_create_size_t()when DEBUG_FS=n

[Stephen Rothwell]

Hi Greg,

On Tue, 20 Jan 2009 21:19:56 -0800 Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
>
> From: Inaky Perez-Gonzalez <inaky@xxxxxxxxxxxxxxx>
> 
> Toralf FÃrster <toralf.foerster@xxxxxx> reported a build failure in
> the WiMAX stack when CONFIG_DEBUG_FS=n
> 
> http://linuxwimax.org/pipermail/wimax/2009-January/000449.html
> 
> This is due to debugfs_create_size_t() missing an stub that returns
> -ENODEV when the DEBUGFS subsystem is not configured in (like the rest
> of the debugfs API).
> 
> This patch adds said stub.
> 
> Reported-by: Toralf FÃrster <toralf.foerster@xxxxxx>
> Signed-off-by: Inaky Perez-Gonzalez <inaky@xxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
>  include/linux/debugfs.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
> index 23936b1..0f5c33b 100644
> --- a/include/linux/debugfs.h
> +++ b/include/linux/debugfs.h
> @@ -162,6 +162,13 @@ static inline struct dentry *debugfs_create_x32(const char *name, mode_t mode,
>  	return ERR_PTR(-ENODEV);
>  }
>  
> +struct dentry *debugfs_create_size_t(const char *name, mode_t mode,

This needs to be "static inline".  See my other email about linux-next
breakage due to this.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature