Re: [patch] x86: Unneeded assignment to tsk in recent x86 change

[Uros Bizjak]

Mikael Pettersson wrote:

>  > Impact: Cleanup.
>  > 
>  > Remove unneeded assignment to tsk in recent x86 change [1].
>  
>
>  > @@ -795,13 +794,12 @@ asmlinkage
>  >  void __kprobes do_page_fault(struct pt_regs *regs, unsigned long error_code)
>  >  {
>  >  	unsigned long address;
>  > -	struct task_struct *tsk;
>  > +	struct task_struct *tsk = current;
>  >  	struct mm_struct *mm;
>  >  	struct vm_area_struct *vma;
>  >  	int write;
>  >  	int fault;
>  >  
>  > -	tsk = current;
>  >  	mm = tsk->mm;
>  >  	prefetchw(&mm->mmap_sem);
>
> but this is neither a fix nor IMO a cleanup (it's inconsistent with
> the other variables in that function)
>   

Hm, I'm not sure I see the inconsistency here. Care to explain this 
inconsistency in a couple of words?

Thanks,
Uros.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/