Re: tty_tiocmset() masks out TIOCM_RI and TIOCM_CD, which breaks rfcomm

From: Adam Bliss
Date: Wed Jan 21 2009 - 13:13:41 EST


Hi, Alan. Thanks for the reply.

On Wed, Jan 21, 2009 at 07:32, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> I would have expected the driver to be remapping RI/CD just as it does
> for the DTR<->DSR RTS<->CTS cable switch around.
>
> It's certainly possible to fix it, but that would need a double check on
> the existing drivers and that passing new suprise bits won't do any harm.
> The real question is what should the right behaviour be - and to me that
> seems to be to logically flip all the lines not just DTR/DSR RTS/CTS

What would you expect the driver to map RI and CD to? I don't think
there are DTE->DCE signals that correspond to RI and CD. Possibly
OUT1 and OUT2 could be used, since I don't think these are used
anywhere else in rfcomm, but this might be unintuitive. I'll let
Marcel address that idea.

--Adam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/