Re: Confusion in usr/include/asm-generic/fcntl.h

From: H. Peter Anvin
Date: Wed Jan 21 2009 - 11:48:51 EST


Arnd Bergmann wrote:
>
> I would prefer using the __BITS_PER_LONG == 64 check directly, because
> it gives you a warning when __BITS_PER_LONG is undefined, whereas the
> #ifdef check gets easily fooled by include order problems. Note that
> this is not a problem in the kernel for CONFIG_* symbols which are
> always defined before the first #include.
>

I fully agree with this. It actually *is* a problem for CONFIG_*
symbols too, since people typo them all the time.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/