Re: [PATCH 1.5/4] cgroup: delay populate css id

[KAMEZAWA Hiroyuki]

On Wed, 21 Jan 2009 01:36:32 -0800
Paul Menage <menage@xxxxxxxxxx> wrote:

> On Mon, Jan 19, 2009 at 9:43 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > +static void populate_css_id(struct cgroup_subsys_state *css)
> > +{
> > +       struct css_id *id = rcu_dereference(css->id);
> > +       if (id)
> > +               rcu_assign_pointer(id->css, css);
> > +}
> 
> I don't think this needs to be split out into a separate function.
ok.

> Also, there's no need for an rcu_dereference(), since we're holding
> cgroup_mutex.
> 
Sure. I'll fix.

I'll merge this behavior to CSS ID patch and post it again.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/