Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)

From: Kenji Kaneshige
Date: Tue Jan 20 2009 - 19:13:48 EST


Rafael J. Wysocki wrote:
[snip]
>> /*
>> * World have broken hardwares, so even spec says numbers are constant,
>> * it would be better to re-check registers after 2nd pci_enable_msix.
>> * Or we just skip this. (However this was what your concern, Rafael?)
>> */
>> if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
>> goto Error;
>
> Well, I think let's not do it for now. If there's a system that actually
> breaks here, then we can introduce the extra checking.
>

Agreed.

Thanks,
Kenji Kaneshige


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/